Fix Book Names #14
Merged
Fix Book Names #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BibleNames_ar.properties: fix typo in Samuel name BibleNames_he.properties: fix abbreviated NT book names with numbers SystemDefault.java: replace AddEsth with EsthGr at David's request CustomVersification.java: avoid crash when json has unsupported osis name.
Added public function to get the short Bible book name for a specific language.
Added 1Meq, 2Meq, 3Meq, 3Bar to BibleBook enumeration. Added 1Meq, 2Meq, 3Meq, 3Bar to Bible Names properties file. Added the missing Apocrypha to the System Default versification. Added Apocrypha chapter verses counts to KJV versification. This should only affect the mapping logic.
Make verse mapping separate from KJV versification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BibleNames_ar.properties: fix typo in Samuel name
BibleNames_he.properties: fix abbreviated NT book names with numbers
SystemDefault.java: replace AddEsth with EsthGr at David's request
CustomVersification.java: avoid crash when json has unsupported osis name.